Stacked Pull Requests | GitKon 2022 | Tomas Reimers, Graphite

Stacked Pull Requests | GitKon 2022 | Tomas Reimers, Graphite

GitKraken

1 год назад

8,869 Просмотров

Ссылки и html тэги не поддерживаются


Комментарии:

@rajpiskala
@rajpiskala - 23.12.2022 06:42

This is such a simple solution to a problem I've had for a long time. Thanks for the clear and well-prepared video!

Ответить
@kiryls1207
@kiryls1207 - 30.09.2023 14:48

we got 99 issues and my branch ain't one

Ответить
@sergiobost7434
@sergiobost7434 - 17.10.2023 19:33

Great idea but this is already possible with rebasing. Rebasing may incur some headaches but most of that can be avoided with good communication amongst teammates.

Ответить
@DontTakeCrack
@DontTakeCrack - 31.10.2023 20:06

"Stacking lets you make many small PRs easily, and without having to wait for review." I don't need a tool to do that right? I can just make small PRs.

Ответить
@idemchenko-js
@idemchenko-js - 09.11.2023 12:00

IMO, to complete the picture, a comparison to trunk-based development is missing in this video. I agree that asking to review massive PRs is very expensive for everyone. However, I'd argue that big PRs are symptoms of a bigger, often organisational problem. If I understand correctly, you are proposing a tool that runs a series of rebases automatically. But I think the main problem is the fact that we need to start a PR in the first place. So, I'd say there are two approaches to working on a single codebase as a team: trunk-based and some sort of branching strategy. I think you need to expand on this one.

As a side note, the bigger issue is that many engineers don't understand what rebase does, and why merging 'main' into a 'branch' is <use your adjective here>. So, I'd say start there first.

Ответить
@3pleFly
@3pleFly - 04.02.2024 19:00

What is this terribly inefficient format of a presentation? Just get to it...

Ответить
@user-kt5pb9pv5y
@user-kt5pb9pv5y - 23.02.2024 02:02

Having worked with stacked PRs at meta for 3 years, then moving to a company that doesnt have it, my productivity seemed to halt. Stacked PRs is one of those things where you dont realize just how incredibly powerful it is until you've used it and its taken away. Good job guys!

Ответить
@mvnkycheez
@mvnkycheez - 11.04.2024 20:46

What is actually the difference between this and just managing feature branches?

Ответить
@AlonchBreak
@AlonchBreak - 16.04.2024 03:56

All this complexity because you needed someone to review your PR but the team is too busy, possibly due to high work in progress (WIP)
This is exactly the opposite of lean, adding more PRs will increase your WIP that inevitable will make all PRs slower and those you need to review too
It may feel like your are going faster but I encourage you compare your deployment frequency if you don't stack.

An alternative solution would be for the team to reduce your collective WIP and leave slack capacity for timely reviews

Ответить